feat(circuitbreaker): remove 429 from circuit breaker failure conditions#276
Draft
ssncferreira wants to merge 1 commit intomainfrom
Draft
feat(circuitbreaker): remove 429 from circuit breaker failure conditions#276ssncferreira wants to merge 1 commit intomainfrom
ssncferreira wants to merge 1 commit intomainfrom
Conversation
ssncferreira
force-pushed
the
ssncf/remove-429-circuit-breaker
branch
5 times, most recently
from
1420860 to
3093fba
Compare
ssncferreira
force-pushed
the
ssncf/remove-429-circuit-breaker
branch
from
3093fba to
bf7088f
Compare
ssncferreira
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rate-limit responses (429) are key-specific errors that will be handled by key failover, not provider-level failures. This cleanly separates key errors (429, 401, 403) from provider errors (503, 504, 529).
Changes
http.StatusTooManyRequestsfromDefaultIsFailureTestCircuitBreaker_429DoesNotTripintegration testThe Anthropic custom
IsFailure(which adds 529) delegates toDefaultIsFailureand requires no changes.Related to: coder/internal#1445
Related to: https://linear.app/codercom/issue/AIGOV-196