chore: upgrade devcontainer to Node 24 on Debian trixie#914
Open
chore: upgrade devcontainer to Node 24 on Debian trixie#914
Conversation
a43307d to
a0f6359
Compare
fa584ad to
ce1eac8
Compare
ce1eac8 to
da2e7ee
Compare
Update the base image from typescript-node:22-bookworm to typescript-node:24-trixie with a pinned digest. Node 24 is backwards compatible and matches the dogfood template. Playwright 1.59+ has full debian13 (trixie) support with correct package names (e.g. libasound2t64). Use --force on pnpm install to suppress the interactive prompt when node_modules needs to be reinstalled from scratch.
da2e7ee to
4b57f92
Compare
- Add DBUS_SESSION_BUS_ADDRESS=disabled: in devcontainer containerEnv to prevent Electron from trying to connect to a non-existent D-Bus daemon. - Add --disable-gpu to integration test launchArgs since GPU rendering is unnecessary for automated tests.
The disabled: transport type produces its own parse errors in Chromium, adding noise rather than reducing it. D-Bus warnings in headless containers are harmless cosmetic noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the devcontainer:
Node 24 + Debian trixie — Update base image from
typescript-node:22-bookwormtotypescript-node:24-trixie(pinned digest). Matches the dogfood vscode-coder template and the>= 22engines constraint. Playwright 1.59+ has fulldebian13support with correct trixie package names (e.g.libasound2t64), resolved in microsoft/playwright#36916.pnpm prompt — Add
--forcetopostCreateCommandto suppress the interactive "modules will be removed and reinstalled" confirmation.Note
Generated by Coder Agents