Repository navigation
🤖 Escape follow-ups from #5736: drawer focus, bell state for screen readers, stale comment #5761
Description
Activity
One more item, from the final review round of #5763:
- Keybind named in a test comment:
src/browser/components/WorkspaceMenuBar/WorkspaceMenuBar.test.tsx:636(the test "lets global shortcuts through while the Workspace details button has focus") says "Escape included (it interrupts a stream)". AGENTS.md forbids repeating keybind values in comments. Fix: say "the stream-interrupt shortcut". Trigger: the next edit of that test.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high- Keybind named in a test comment:
Two more items, from the final independent check of #5763 (
tests/bugbash/repros/detailsShortcuts.e2e.ts). Trigger for both: the next edit of that repro.- Keys named in the header comment: line 1 says "after Ctrl+Shift+D and Escape". AGENTS.md forbids repeating keybind values in comments. Fix: describe the shortcut and the dismiss key by role.
- Notifications restore not in a
finally: the repro turns "Notify on all responses" on, then off at the end. If an earlier assertion fails, the setting stays on, and the later reprosescapeClosesOverlaysandnotificationsShortcutcan fail as knock-on failures, because repros share one workspace per run. Fix: put the restore in afinallythat starts before the first state change.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high
Problem: The final check of #5736 found three small follow-ups. None blocks #5736.
aria-pressedfrom the notifications bell, because a click no longer toggles the setting. The accessible name "Notifications" does not say whether notifications are on. Fix idea: carry the state inaria-description.src/browser/hooks/useAIViewKeybinds.tssays the overlay check covers "(tutorial, narrow-screen drawer)". The tutorial part was removed from 🤖 fix: Escape closes the agent picker, sidebar drawer and notifications popover #5736 (see 🤖 Escape does not close the tutorial tooltip #5701).Priority P3. Size S. Follow-up of #5736.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high