Skip to content

ci: quita Chromatic; compuerta = build de Storybook, PRs con auto-merge #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
A-PachecoT merged 1 commit into from
Oct 13, 2026
Merged

ci: quita Chromatic; compuerta = build de Storybook, PRs con auto-merge #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions .github/workflows/chromatic.yml
View file
Open in desktop

This file was deleted.

37 changes: 37 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: CI

# Reemplaza a Chromatic (decisión de André, 2026-10-12: «creo q no lo necesitamos, q se mergee
# automático»). La compuerta es la misma que daba Chromatic en la práctica: que Storybook compile.
# Typecheck y tests corren como señal y no bloquean: en main ya fallaban el 2026-10-12
# (3 errores de tsc, 2 tests rojos), y gatear en eso trabaría todo PR con auto-merge.
# El Storybook publicado sigue en Cloudflare Pages (deploy.yml).

on:
push:
branches: [main]
pull_request:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: actions/setup-node@v4
with:
node-version: 20
cache: npm

- name: Install dependencies
run: npm ci

- name: Build Storybook
run: npm run build-storybook

- name: Typecheck (señal, no bloquea)
run: npm run typecheck
continue-on-error: true

- name: Tests (señal, no bloquea)
run: npm test
continue-on-error: true
3 changes: 2 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,8 @@ npm run test:coverage # With coverage

Storybook is deployed to **Cloudflare Pages** (not Railway) at **ui.cofoundy.dev**.
- **Auto-deploy on push to `main`** via GitHub Actions (`.github/workflows/deploy.yml`)
- Chromatic visual testing also runs on push
- No visual-regression service: Chromatic was removed on 2026-10-12. `.github/workflows/ci.yml` gates every PR on `npm run build-storybook`; typecheck and tests run as signal only.
- PRs auto-merge once CI is green (repo setting `allow_auto_merge`; `gh pr merge --auto --squash`).
- No manual deploy needed — just push

## Products Using This Package
Expand Down
32 changes: 4 additions & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^4.3.4",
"@vitest/coverage-v8": "^4.0.0",
"chromatic": "^13.3.5",
"jsdom": "^27.0.0",
"opentype.js": "^1.3.4",
"storybook": "^8.6.14",
Expand Down
Loading