support for coredao go-ethereum fork - #164
Merged
finnbledsoe-cb merged 2 commits intoJul 20, 2026
Merged
Conversation
coredao-org/core-chain forks go-ethereum and diverges in the CreateBloom signature: upstream v1.15.5 is CreateBloom(receipt *Receipt) while core-chain v1.0.22 is CreateBloom(receipts Receipts). The block-validation path added in coinbase#151 calls CreateBloom with a single receipt, which does not compile against the fork. Wrap it in EthTypes.Receipts so the SDK builds against coredao-org/core-chain. This mirrors the arbitrum-go-ethereum-support branch pattern: fork-specific compatibility lives on a chain branch/pre-release tag rather than master, since the change is mutually exclusive with upstream go-ethereum. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
🟡 Heimdall Review Status
|
Follow-up to the CreateBloom fix so this chain-specific branch actually compiles and tests against coredao-org/core-chain (previously the go.mod still pulled stock go-ethereum, so CI failed to build). - go.mod: replace go-ethereum => coredao-org/core-chain v1.0.22 plus the matching kzg/btcd/go-ipa/gnark-crypto pins core-chain requires. Kept in sync with rosetta-coredao's go.mod. - examples/ethereum/config/config.go: the fork does not export the Holesky/Sepolia genesis hashes, so use literal placeholder hashes. (Will be squashed with the CreateBloom commit before the final tag.) Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
finnbledsoe-cb
changed the base branch from
master
to
coredao-go-ethereum-support-2
July 20, 2026 21:36
finnbledsoe-cb
merged commit Jul 20, 2026
b699ed4
into
coinbase:coredao-go-ethereum-support-2
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coredao-org/core-chain forks go-ethereum and diverges in the CreateBloom signature: upstream v1.15.5 is CreateBloom(receipt *Receipt) while core-chain v1.0.22 is CreateBloom(receipts Receipts). The block-validation path added in #151 calls CreateBloom with a single receipt, which does not compile against the fork. Wrap it in EthTypes.Receipts so the SDK builds against coredao-org/core-chain.
This mirrors the arbitrum-go-ethereum-support branch pattern: fork-specific compatibility lives on a chain branch/pre-release tag rather than master, since the change is mutually exclusive with upstream go-ethereum.
Generated with Claude Code
Fixes # .
Motivation
Solution
Open questions