fix: add nil checks for KeyPair in SaveAccountWorker - #539
Open
Kubudak90 wants to merge 1 commit into
Open
Conversation
The SaveAccountWorker function validates AccountIdentifier but does not validate KeyPair before passing it to StoreKey. This could cause nil pointer dereference panics if KeyPair is nil or has nil/empty fields. Add validation for: - KeyPair is not nil - KeyPair.PublicKey is not nil - KeyPair.PrivateKey is not empty This follows the same validation pattern used elsewhere in the codebase.
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
SaveAccountWorkerfunction validatesAccountIdentifierusingasserter.AccountIdentifier()but does not validateKeyPairbefore passing it toStoreKey. This could cause nil pointer dereference panics ifKeyPairis nil or has nil/empty fields.Changes
Add validation for:
KeyPairis not nilKeyPair.PublicKeyis not nilKeyPair.PrivateKeyis not emptyBug Details
The
KeyPairstruct contains:PublicKey *types.PublicKey(pointer, can be nil)PrivateKey []byte(can be nil/empty)If these fields are nil/empty,
StoreKeycould panic or store invalid data.Testing
This fix follows the same validation pattern used elsewhere in the codebase (e.g.,
asserter.AccountIdentifier,asserter.PublicKey).Fixes potential nil pointer dereference in constructor worker.