This repository was archived by the owner on Jan 31, 2025. It is now read-only.
Partial tidy up of layout code#31
Draft
connorjward wants to merge 8 commits into
Draft
Conversation
* Should simplify the thesis write up. * Much more tidying + docs are required. * Appears to pass tests in Firedrake.
In particular indices now propagate additional target paths which can only be handled at the point of indexing an axis tree.
My first Firedrake test is now passing again. I expect parallel to be quite a hurdle though.
Fair number of Firedrake tests now pass.
The new method is much simpler and more minimal. My key insight is that it is much simpler to just think about tabulating each axis separately and then add the expressions together. Combining tabulations for different levels is just another optimisation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relevant Firedrake branch is
connorjward/pyop3-redo-tabulation.