BREAKING: Remove wildcard imports for ETSI/ IEEE standards#15
Open
jbeyerstedt wants to merge 2 commits into
Open
BREAKING: Remove wildcard imports for ETSI/ IEEE standards#15jbeyerstedt wants to merge 2 commits into
jbeyerstedt wants to merge 2 commits into
Conversation
jbeyerstedt
force-pushed
the
breaking/remove-wildcard-imports
branch
from
eaa8368 to
896d57a
Compare
Import from the ieee1609dot2 and en302636_4_1 modules now.
jbeyerstedt
force-pushed
the
breaking/remove-wildcard-imports
branch
from
896d57a to
7dbda2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14 has refactored the message definitions to be one file per referenced standard, but kept the public interface the same by using a wildcard "re-export" of the message types.
But this clutters the docs quite a lot and it would be nicer to have the "external" definitions fully contained in their own modules. Therefore this PR removes the wildcard "use" statements and updates all usages of the types.
Users of this crate need to add
en302636_4_1orieee1609dot2to their type qualifiers (or use a wildcard import).