Reject empty path arguments - #771
Merged
Merged
Conversation
smcv
reviewed
Aug 26, 2026
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
The security fixes in 0.12.0 seem to have mostly addressed this as a side-effect. Is this still necessary?
smcv
requested changes
Aug 26, 2026
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
Please add a Signed-off-by to your commit(s) to indicate that the Developer Certificate of Origin can be applied to your contribution.
See https://github.com/containers/common/blob/main/CONTRIBUTING.md for details.
(@alexlarsson, @cgwalters: we should probably add a CONTRIBUTING.md to this project too, even if it's just a cross-reference to that one)
Path arguments become real filenames by concatenation onto "/oldroot/" or "/newroot/", so an empty path turns into the root directory. `--bind-try "" DEST` therefore gave the sandbox read/write access to the whole filesystem, and an empty destination replaced the sandbox root in the same way. The variants without `-try` failed earlier, because realpath() rejects an empty source, but the other options that take a path had no check at all. Check every path argument during option parsing, and report an empty one as a usage error. Signed-off-by: abhinavmir <atg271@gmail.com>
AbhinavMir
force-pushed
the
reject-empty-path-arguments
branch
from
August 26, 2026 18:39
4310388 to
9fb7980
Compare
Collaborator
|
(As a general Github thing, please leave a comment after fixing issues and pushing a new version - otherwise maintainers aren't notified that your PR is ready for review again.) |
smcv
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#715