Repository navigation
feat(visual-builder): open Visual Editor in a new tab from Start Editing - #655
Draft
kirtesh-cstk wants to merge 1 commit into
Draft
kirtesh-cstk wants to merge 1 commit into
kirtesh-cstk wants to merge 1 commit into
Conversation
Start Editing now opens Visual Editor in a tab named for this stack and site, instead of leaving the page. That tab is the relay a docked panel needs, so the page asks it whether to dock; for a stack that has not enabled docking the new tab is simply Visual Editor. If the browser refuses the window, the link is followed as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kirtesh-cstk
added this pull request to stack #656
September 26, 2026 10:26
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start Editing now opens Visual Editor in a new tab instead of leaving the page. That tab is the relay a docked panel needs, so the page asks it whether to dock. For a stack that has not enabled docking, the new tab is simply Visual Editor.
Changes
openRelayAndDock(href)opens Visual Editor in a tab named for the stack and site (csBuilderRelay:<api key>:<origin>), so two sites never share a tab and a page can find its own again. It then asks that tab whether to dock, waiting up to 60 seconds because the tab boots a whole Visual Editor first.Test plan
startEditingButton.newTab.test.tsx: the click opens the relay tab and prevents navigation; a refused window falls through to the link.builderPanel.test.ts: the window name, and the hello sent to the new tab.hrefis the same as before. Full suite: 115 files, 893 passed.Behaviour change for every site: Start Editing used to navigate the same tab and now opens a new one. That is intended, since it is how the new tab can tell whether the stack docks or edits the usual way.
🤖 Generated with Claude Code