Skip to content

feat(visual-builder): open Visual Editor in a new tab from Start Editing - #655

Draft
kirtesh-cstk wants to merge 1 commit into
feat/docked-panel/dockfrom
feat/docked-panel/start-editing
Draft

kirtesh-cstk wants to merge 1 commit into
feat/docked-panel/dockfrom
feat/docked-panel/start-editing

Conversation

@kirtesh-cstk

@kirtesh-cstk kirtesh-cstk commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Start Editing now opens Visual Editor in a new tab instead of leaving the page. That tab is the relay a docked panel needs, so the page asks it whether to dock. For a stack that has not enabled docking, the new tab is simply Visual Editor.

Changes

  • openRelayAndDock(href) opens Visual Editor in a tab named for the stack and site (csBuilderRelay:<api key>:<origin>), so two sites never share a tab and a page can find its own again. It then asks that tab whether to dock, waiting up to 60 seconds because the tab boots a whole Visual Editor first.
  • The Start Editing link calls it on click. If the browser refuses the window, the link is followed as before.

Test plan

  • New startEditingButton.newTab.test.tsx: the click opens the relay tab and prevents navigation; a refused window falls through to the link.
  • New cases in builderPanel.test.ts: the window name, and the hello sent to the new tab.
  • The existing Start Editing tests pass unchanged; the link's href is the same as before. Full suite: 115 files, 893 passed.
  • Checked in a browser: Start Editing opened Visual Editor in a new tab and the page stayed. The panel docked for a stack with docking on, and did not for a stack with it off.

Behaviour change for every site: Start Editing used to navigate the same tab and now opens a new one. That is intended, since it is how the new tab can tell whether the stack docks or edits the usual way.


🤖 Generated with Claude Code

Start Editing now opens Visual Editor in a tab named for this stack and
site, instead of leaving the page. That tab is the relay a docked panel
needs, so the page asks it whether to dock; for a stack that has not
enabled docking the new tab is simply Visual Editor. If the browser
refuses the window, the link is followed as before.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@kirtesh-cstk
kirtesh-cstk added this pull request to stack #656 September 26, 2026 10:26
@kirtesh-cstk kirtesh-cstk changed the title feat/docked panel/start editing feat(visual-builder): open Visual Editor in a new tab from Start Editing Sep 26, 2026
@snyk-io

snyk-io Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.09% 2608 / 3830
🔵 Statements 66.93% 2658 / 3971
🔵 Functions 65.78% 473 / 719
🔵 Branches 62.38% 1574 / 2523
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/startEditingButton.tsx 100% 87.5% 100% 100%
src/visualBuilder/panel/builderPanel.ts 86.36% 69.04% 94.11% 91.89% 52, 76, 123, 125, 126, 161-172
Generated in workflow #922 for commit 6890105 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant