Repository navigation
Test chained brands on zod objects in zodToConvex - #1053
Merged
Merged
Conversation
`z.object(…).brand("A").brand("B")` should keep both brands in the
converted validator's type. Since #1051, only the outermost brand is
kept.
commit: |
Since #1051, the brand of a branded object came from `$ZodBranded<infer Inner, infer Brand>`, which only gives the outermost brand, and the inner brands were dropped from `Inner`'s inferred type. Take the brands from the object's own inferred type instead, so that `.brand("A").brand("B")` keeps both.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z.object(…).brand("A").brand("B")should keep both brands in the type of the converted validator. Since #1051,zodToConvexonly keeps the outermost brand (reported by cubic on #1051).This PR first adds the regression test (expected to fail CI), then the fix.