feat(vllm): compile GLM-5.3 native support on 0.28 - #221
Conversation
|
@alexeldeib also has other patch here - https://github.com/coreweave/ml-containers/tree/main/vllm-tensorizer ... maybe we should use all the patches in the same way. |
3c6cb1b to
7485122
Compare
alexeldeib
left a comment
There was a problem hiding this comment.
seems okay assuming it works 🤞
Let's strip out the 2 forks as soon as convenient in follow up when upstream is ready
|
@sihang-s Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/33115583554 |
89a5bff to
8292f08
Compare
|
@sihang-s Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/33140149775 |
b342bee to
6682d04
Compare
6682d04 to
bcbe5f0
Compare
|
@sihang-s Build complete, success: https://github.com/coreweave/ml-containers/actions/runs/33155124037 |
| # renovate-release: datasource=github-releases depName=vllm-project/vllm currentValue=v0.28.0 versioning=pep440 | ||
| - vllm-commit: '2cf0a6915ce544dc493a0990f2ea38d81601128a' | ||
| flashinfer-commit: 'v0.6.16.post3' | ||
| flashinfer-commit: 'e62941a1da605fb9b3c8c50b23c9720df12cf6b4' |
There was a problem hiding this comment.
Just to confirm this is a release right, not an arbitrary commit ?
There was a problem hiding this comment.
It's from a RC tag. Pinging commit SHA here for immutable build.
Summary
nightly-v0.6.18-20260819while keeping CUDA13.2.1Compiled subset
cmake/external_projects/vllm_flash_attn.cmakecsrc/libtorch_stable/cache_kernels.cuThese files must exist before wheel/native-extension compilation because they pin the flash-attention native dependency and add compiled
head_dim=512cache-kernel support.Source provenance
2cf0a6915ce544dc493a0990f2ea38d81601128a0f82208cb1d01e723bb25b607217a1adfb0cfc30933876c388fb129ad82590660e6506614559cb86ee3fda10e0b9d82b71bda534bc2954d3176e6ded(nightly-v0.6.18-20260819)08ddfbcd2e89b2f4b68391825817909e30d445e2(already included in the pinned source)vllm-project/flash-attention@4eb29359a51b4fe67c8c0f0c5e931236971aa49200e84751bd79e3140fc4344223d9997548605d47ba66f4ee51d108520831d762Existing native patch consolidation
vllm-patches/stacka047e2543da570a64d1bbfeac4fe44eff3e87a81v0.28.0source predates the fix; the first containing release tag isv0.28.1rc0d4e98e4b302ecdaf463120b7ca1b1f567c18525b742ae83d2d9a445c042173e9Compatibility contract
The downstream runtime patch must use the same vLLM base and reviewed upstream head. Python/runtime-only upstream deltas update only the downstream layer; CMake, CUDA/C++, native-binding, native-dependency, or FlashInfer changes require a new compiled image and digest.
Validation
linux/amd64andlinux/arm64with no warningsvllm-downloaderandflashinfer-downloaderstages pass forlinux/arm64Follow-up
After CI publishes the new immutable multi-arch digest, downstream consumers can pin this compiled image and layer the Python/runtime GLM backport.