fix(core): expose getCompleteScalarDataArray on dynamic volume voxel manager#2808
Merged
Merged
Conversation
…manager The dynamic (4D) volume voxel manager only exposed per-dimension-group scalar accessors, so consumers that call the generic getCompleteScalarDataArray() on a reference volume - such as segmentation statistics (getStatistics -> calculateVolumeStatistics) - threw for segmentations on dynamic volumes. Delegate it to the active dimension group's scalar data.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe dynamic volume voxel manager now exposes ChangesDynamic scalar data access
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sedghi
added a commit
to OHIF/Viewers
that referenced
this pull request
Jul 15, 2026
…ts shim cs3d 5.6.2 adds getCompleteScalarDataArray to the dynamic volume voxel manager (cornerstonejs/cornerstone3D#2808), so the temporary shim in the cornerstone-dynamic-volume extension is no longer needed. The chart mask (getOrCreateSegmentationVolume) and hanging-protocol registration fixes remain.
sedghi
added a commit
to OHIF/Viewers
that referenced
this pull request
Jul 15, 2026
… volumes (#6149) Bumps @cornerstonejs to 5.6.2 (includes cornerstonejs/cornerstone3D#2808), resolves the chart mask via getOrCreateSegmentationVolume, and registers the chart display set with the hanging protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dynamic (4D) volume voxel manager only exposed per-dimension-group scalar accessors, so consumers that call the generic getCompleteScalarDataArray() on a reference volume - such as segmentation statistics (getStatistics -> calculateVolumeStatistics) - threw for segmentations on dynamic volumes. Delegate it to the active dimension group's scalar data.
Summary by CodeRabbit