Skip to content

fix(core): expose getCompleteScalarDataArray on dynamic volume voxel manager#2808

Merged
sedghi merged 1 commit into
mainfrom
fix/dynamic-volume-complete-scalar-data
Jul 15, 2026
Merged

fix(core): expose getCompleteScalarDataArray on dynamic volume voxel manager#2808
sedghi merged 1 commit into
mainfrom
fix/dynamic-volume-complete-scalar-data

Conversation

@sedghi

@sedghi sedghi commented Jul 15, 2026

Copy link
Copy Markdown
Member

The dynamic (4D) volume voxel manager only exposed per-dimension-group scalar accessors, so consumers that call the generic getCompleteScalarDataArray() on a reference volume - such as segmentation statistics (getStatistics -> calculateVolumeStatistics) - threw for segmentations on dynamic volumes. Delegate it to the active dimension group's scalar data.

Summary by CodeRabbit

  • New Features
    • Added access to complete scalar voxel data through dynamically managed volume data.
    • Ensures the active dimension group’s full scalar data can be retrieved consistently.

…manager

The dynamic (4D) volume voxel manager only exposed per-dimension-group scalar accessors, so consumers that call the generic getCompleteScalarDataArray() on a reference volume - such as segmentation statistics (getStatistics -> calculateVolumeStatistics) - threw for segmentations on dynamic volumes. Delegate it to the active dimension group's scalar data.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d62b1718-d930-4f82-86e3-b70cb02a9d7e

📥 Commits

Reviewing files that changed from the base of the PR and between e0d2d33 and e75a161.

📒 Files selected for processing (1)
  • packages/core/src/utilities/VoxelManager.ts

📝 Walkthrough

Walkthrough

The dynamic volume voxel manager now exposes getCompleteScalarDataArray, delegating retrieval to the currently active dimension group.

Changes

Dynamic scalar data access

Layer / File(s) Summary
Expose active scalar data accessor
packages/core/src/utilities/VoxelManager.ts
Adds getCompleteScalarDataArray to the dynamic voxel manager and delegates calls to the active dimension group.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: wayfarer3130, kofmania

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the bug and fix, but it omits the required template sections for Context, Changes & Results, Testing, and Checklist. Reformat the PR body to fill in the template sections, add testing details, and complete the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific, accurate, and follows the semantic-release fix(core): format for the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dynamic-volume-complete-scalar-data

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sedghi
sedghi merged commit 5aae6db into main Jul 15, 2026
17 checks passed
@sedghi
sedghi deleted the fix/dynamic-volume-complete-scalar-data branch July 15, 2026 22:10
sedghi added a commit to OHIF/Viewers that referenced this pull request Jul 15, 2026
…ts shim

cs3d 5.6.2 adds getCompleteScalarDataArray to the dynamic volume voxel manager (cornerstonejs/cornerstone3D#2808), so the temporary shim in the cornerstone-dynamic-volume extension is no longer needed. The chart mask (getOrCreateSegmentationVolume) and hanging-protocol registration fixes remain.
sedghi added a commit to OHIF/Viewers that referenced this pull request Jul 15, 2026
… volumes (#6149)

Bumps @cornerstonejs to 5.6.2 (includes cornerstonejs/cornerstone3D#2808), resolves the chart mask via getOrCreateSegmentationVolume, and registers the chart display set with the hanging protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant