fix(tools): support contour segmentation undo and redo#2817
Draft
sedghi wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderBackendsenum nameRoot cause
The planar freehand tool initially records an annotation-creation memo for the source stroke. Contour boolean processing then removes that source annotation and rebuilds the resulting contour annotations, leaving the memo pointed at an annotation that no longer exists. Undo therefore could not remove the committed contour, and redo could restore the obsolete source stroke.
This change replaces that provisional memo in-place with a memo that swaps the complete pre-stroke and post-stroke annotation sets, preserving a single undo step for creation, merges, and holes.
Validation
corepack pnpm run test:vitest:browser tests/vitest-browser/undoRedoHistory.browser.test.ts— 9 passed, 1 expected failurecorepack pnpm exec jest packages/core/test/utilities/historyMemo.jest.js --runInBand— 5 passedcorepack pnpm exec tsc --project packages/core/tsconfig.jsoncorepack pnpm exec tsc --project packages/tools/tsconfig.jsongit diff --check