Add output history replay - #32
Open
bigfactory wants to merge 1 commit into
Open
Conversation
Retain bounded process output history for reattach while filtering terminal query sequences that would otherwise feed responses back into the shell.
Contributor
|
There is another class of controls you will want to filter, the persistent state controls. Probably the common ones are the 'alternate screen' selection and the mouse control. The thing is you don't want to remove them, you want to hold the last state seen before the beginning of the buffer. Unfortunately, it would also be nice to reset those when detaching; which would mean a lot more proactive understanding. Also |
bigfactory
force-pushed
the
output-history-replay
branch
from
June 22, 2026 07:50
53b263e to
9f834a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-H <bytes>to configure history size, with-H 0disabling replay.Test Plan
make -C /Users/bytedance/Github/dtach-H 0disables history replay.-Hvalues are rejected.