skiplist: prevent Range iterator from rewinding after exhaustion#1252
Open
cong-or wants to merge 1 commit into
Open
skiplist: prevent Range iterator from rewinding after exhaustion#1252cong-or wants to merge 1 commit into
cong-or wants to merge 1 commit into
Conversation
cong-or
force-pushed
the
fix-skiplist-range-rewind
branch
from
May 4, 2026 21:26
e586243 to
1ab7e07
Compare
taiki-e
reviewed
Jul 11, 2026
| range: R, | ||
| guard: &'g Guard, | ||
| _marker: PhantomData<fn() -> Q>, // covariant over `Q` | ||
| finished: bool, |
Member
There was a problem hiding this comment.
Hmm. Unless it's necessary for correctness, I think it's generally preferable to use fuse rather than "adding an extra flag just to provide FusedIterator's behavior".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1142 — Range iterators rewound to the first element after exhaustion.
When the bounds check failed,
headwas set toNone. Next call interpretedthat as "haven't started yet" and searched from
start_bound()again.Added a
finishedflag toRange/RefRange, set only when bounds areexceeded. Iter/RefIter left unchanged — their rewind on concurrent inserts
is intentional.
Also added
FusedIteratorimpls for Range in base, map, and set.