Skip to content

fix: crash on incoming call while unmarshalling CallInvite - #332

Merged
cybex-dev merged 5 commits into
masterfrom
fix/android_crash_on_accept
Aug 5, 2026
Merged

fix: crash on incoming call while unmarshalling CallInvite #332
cybex-dev merged 5 commits into
masterfrom
fix/android_crash_on_accept

Conversation

@cybex-dev

@cybex-dev cybex-dev commented Aug 5, 2026

Copy link
Copy Markdown
Owner

This pull request addresses a critical crash on Android devices when receiving a CallInvite, caused by unmarshalling errors in some Telecom/ConnectionService implementations (notably on Samsung devices). The solution avoids passing complex CallInvite objects between processes by instead using call SIDs (simple strings), and manages pending and cancelled invites more robustly. It also updates the Gradle wrapper version.

Android Crash Fixes and Call Handling Improvements:

  • Fix crash due to unmarshalling error with CallInvite:
    • Instead of passing the CallInvite object via Bundles (which caused ClassNotFound exceptions in some environments), the code now passes only the call SID (String) and manages the actual CallInvite objects in a local map (pendingCallInvites). This prevents marshalling issues and ensures safer cross-process communication. [1] [2] [3] [4] [5] [6]
    • Cancelled invites are tracked in a new cancelledCallInvites set, ensuring that invites cancelled before a connection is created are handled gracefully and do not result in ringing or missed calls being incorrectly reported. [1] [2] [3]
    • Pending invites are properly cleaned up if connection creation fails, preventing leaks.

Dependency Upgrades:

  • Gradle Wrapper Update:
    • The Gradle wrapper is updated from version 8.8 to 8.11.1 for improved build reliability and compatibility.

Code Maintenance:

  • Refactoring and Documentation:
    • Improved comments and documentation for new fields and logic related to pending/cancelled invites. [1] [2]
    • Removal of unused constants and redundant class loader assignments. [1] [2]

These changes significantly improve Android call invite handling stability and reliability, especially on devices with custom Telecom implementations.

@cybex-dev cybex-dev self-assigned this Aug 5, 2026
@cybex-dev cybex-dev added Android bug Something isn't working labels Aug 5, 2026
@cybex-dev
cybex-dev marked this pull request as ready for review August 5, 2026 17:14
@cybex-dev
cybex-dev merged commit 9a70c5f into master Aug 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant