fix: crash on incoming call while unmarshalling CallInvite - #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a critical crash on Android devices when receiving a
CallInvite, caused by unmarshalling errors in some Telecom/ConnectionService implementations (notably on Samsung devices). The solution avoids passing complexCallInviteobjects between processes by instead using call SIDs (simple strings), and manages pending and cancelled invites more robustly. It also updates the Gradle wrapper version.Android Crash Fixes and Call Handling Improvements:
CallInvite:CallInviteobject via Bundles (which caused ClassNotFound exceptions in some environments), the code now passes only the call SID (String) and manages the actualCallInviteobjects in a local map (pendingCallInvites). This prevents marshalling issues and ensures safer cross-process communication. [1] [2] [3] [4] [5] [6]cancelledCallInvitesset, ensuring that invites cancelled before a connection is created are handled gracefully and do not result in ringing or missed calls being incorrectly reported. [1] [2] [3]Dependency Upgrades:
Code Maintenance:
These changes significantly improve Android call invite handling stability and reliability, especially on devices with custom Telecom implementations.