Refactor/silentpayments transaction shared secret - #141
Open
Sosthene00 wants to merge 7 commits into
Open
Conversation
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
from
June 23, 2026 13:20
56397f2 to
98cf407
Compare
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
from
July 22, 2026 11:12
98cf407 to
c2b7fa8
Compare
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
3 times, most recently
from
August 12, 2026 10:35
fb6d7c6 to
d828248
Compare
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
2 times, most recently
from
August 26, 2026 11:38
a392e7c to
76d89e6
Compare
Only accepts selections whose implied fee rate stays within the requested rate (modulo vbyte rounding): selections that would absorb the leftover excess into the fee are rejected, and among the accepted ones the fee is minimized. When no selection can honor the rate the strategy is simply absent from the results, leaving callers free to fall back to the other strategies.
…roduce `PublicTweakData`
Sosthene00
force-pushed
the
refactor/silentpayments-transaction-shared-secret
branch
from
September 8, 2026 08:43
76d89e6 to
a721c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedSecretwithTransactionSharedSecret, that carries both the ECDH point and recipient scan key.PublicTweakDatafor receiver-side shared secret derivation usingTransactionInputs.calculate_label_hash,calculate_shared_secret_hash) and addNormalizedSecretKeytype for taproot key normalization.PartialSecret/calculate_partial_secretsending API unchanged for now.