Patch/3 vendoritems recovery - #1064
Open
Emissaryx wants to merge 60 commits into
Open
Conversation
… stats Share view links now bake in an absolute start/end timestamp instead of a relative range, so a copied link keeps showing the same window. Standouts and roster-preview column order now matches the full Scenario detail page. Expanded match rows in Scenario Breakdown show the score. Dropped the invented Overall contribution stat - Standouts now sort by real stats directly, and Top contributor is now Top killer with a tooltip. Added tooltips for Balance thresholds. Filter selects use Bulma's select component.
Averaging or taking the median over 1-2 scenarios lets a single lucky match dominate the ranking regardless of which stat is selected. Reproduced live: Destruction Standouts ranked by Kill damage, Average view, put a 1-scenario player at the top. Default the minimum-scenarios filter to 10+ whenever View is Average or Median; Totals keeps the old 1+ default. An explicit lbMin in the URL always overrides this.
Reworked from one flat sortable table into two team sections grouped by role (Tank/Melee DPS/Ranged DPS/Healer) with a team totals row, matching the roster preview pattern and the maartenson.net reference. Every stat cell also shows the player's share of their team total for that stat, e.g. Kill dmg 27K (11%), so healer/dps/tank contribution can be compared honestly without a combined score. Sorting still works, applied within each role group.
Default full-window scenario batch loads to Apollo's cache-first fetch policy so leaving /scenarios (e.g. clicking into a character) and returning reuses the already-fetched window instead of redownloading. The Refresh button still forces a true network-only fetch via a ref flag.
…hits Follow-up to the previous commit: switching the batch loader to cache-first didn't actually help, because getTimeFilters recomputes "now" fresh on every mount for relative ranges (1h/24h/7d/etc), so startTime.gte drifted by a few seconds/minutes each time and Apollo saw it as a brand new query. Rounding "now" down to a 5-minute bucket keeps the query variables identical across remounts within that window, so returning to /scenarios now actually reuses the cache instead of redownloading.
…rylines Added links to existing pages in the Home component.
Alphabetized the tab links in the Home nav (Class Activity, Creatures, Guilds, Instances, Items, Players, Quests, Scenarios, Skirmishes, Storylines). Ranked stays excluded per earlier decision.
Refactored select elements into div wrappers for better styling.
Removed unused imports and navigation links for clarity.
Added styles for filter grid and summary bar to unify appearance across pages.
Replaced card layout with a filter grid for search functionality.
Updated the layout of the Items page by changing the container class and modifying the search and filter elements for better organization.
Refactor career filter layout to use a grid format and improve accessibility.
Refactor VendorItems component to load all vendor items in one go instead of paginating with server-side queries. Update search functionality and adjust item display logic.
Add a scrollable card for vendor items to keep the list in view.
Added error handling for malformed vendor items.
Instead of discarding an entire 50-item page when a single row references deleted data (which nulls the whole array under GraphQL's non-null propagation rules), binary-split the failing range and retry each half until the bad row(s) are isolated. Recovers all valid items in a page and only drops the specific malformed rows.
✅ Deploy Preview for curious-caramel-c7f0d8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.