Skip to content

fix: Create plugin client with logger set to log level of PluginStore #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srager13 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Create plugin client with logger set to log level of PluginStore #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a86c4db
Fix: set the plugin client's log level to PluginStore log level
srager13 Jul 1, 2025
3e3a1aa
Use strings to convert log levels from logrus to hclog
srager13 Jul 1, 2025
f4b632a
add function to convert logrus loglevel to hclog loglevel
srager13 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pkg/store/kubeconfig_store_plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"fmt"
"os/exec"

"github.com/hashicorp/go-hclog"
"github.com/hashicorp/go-plugin"
"github.com/sirupsen/logrus"
"gopkg.in/yaml.v3"
Expand Down Expand Up @@ -49,6 +50,22 @@ func NewPluginStore(store types.KubeconfigStore) (*PluginStore, error) {
}, nil
}

func convertLogrusLevelToHclogLevel(level logrus.Level) hclog.Level {
switch level {
case logrus.TraceLevel:
return hclog.Trace
case logrus.DebugLevel:
return hclog.Debug
case logrus.InfoLevel:
return hclog.Info
case logrus.WarnLevel:
return hclog.Warn
default:
// Default to Error level for any other logrus levels (e.g. Fatal or Panic)
return hclog.Error
}
}

// InitializePluginStore initializes the plugin store
func (s *PluginStore) InitializePluginStore() error {

Expand All @@ -58,6 +75,11 @@ func (s *PluginStore) InitializePluginStore() error {
Cmd: exec.Command(s.Config.CmdPath, s.Config.Args...),
AllowedProtocols: []plugin.Protocol{
plugin.ProtocolNetRPC, plugin.ProtocolGRPC},
Logger: hclog.New(&hclog.LoggerOptions{
Output: hclog.DefaultOutput,
Level: convertLogrusLevelToHclogLevel(s.Logger.Level),
Name: "plugin",
}),
})

// Connect via RPC
Expand Down