Skip to content

[cronet_http] Add DNS configuration options to CronetEngine.build#1945

Draft
fryette wants to merge 1 commit into
dart-lang:masterfrom
fryette:cronet-dns-options
Draft

[cronet_http] Add DNS configuration options to CronetEngine.build#1945
fryette wants to merge 1 commit into
dart-lang:masterfrom
fryette:cronet-dns-options

Conversation

@fryette

@fryette fryette commented Jul 2, 2026

Copy link
Copy Markdown

Expose Cronet DnsOptions through new CronetEngine.build parameters: useBuiltInDnsResolver, enableStaleDns, persistHostCache and persistHostCachePeriod.

Cronet enables QUIC by default, and with QUIC enabled it resolves hosts through its built-in DNS resolver. On some cellular networks and in background isolates (e.g. WorkManager) that resolver fails with ERROR_HOSTNAME_NOT_RESOLVED while the system resolver works. useBuiltInDnsResolver: false forces the system resolver; enableStaleDns/persistHostCache allow a freshly created engine to serve recently used hosts from a persisted cache.

setDnsOptions is available on the stable CronetEngine.Builder in both cronet-api artifacts the plugin ships (play-services and embedded), and the Java API layer transparently falls back to an experimental-options JSON patch on implementations that do not support DnsOptions natively, so no experimental bindings are required.

Helps with #1217

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

Expose Cronet DnsOptions through new CronetEngine.build parameters:
useBuiltInDnsResolver, enableStaleDns, persistHostCache and
persistHostCachePeriod.

Cronet enables QUIC by default, and with QUIC enabled it resolves hosts
through its built-in DNS resolver. On some cellular networks and in
background isolates (e.g. WorkManager) that resolver fails with
ERROR_HOSTNAME_NOT_RESOLVED while the system resolver works.
useBuiltInDnsResolver: false forces the system resolver;
enableStaleDns/persistHostCache allow a freshly created engine to serve
recently used hosts from a persisted cache.

setDnsOptions is available on the stable CronetEngine.Builder in both
cronet-api artifacts the plugin ships (play-services and embedded), and
the Java API layer transparently falls back to an experimental-options
JSON patch on implementations that do not support DnsOptions natively,
so no experimental bindings are required.

Helps with dart-lang#1217
@google-cla

google-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant