Repository navigation
Support SQL casts from stored and composed Variant values - #107
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Contributor
|
This is good. One thing I noticed is that the type planner isn't registered as part of register_all |
Contributor
14 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
CAST(v AS type)andTRY_CAST(v AS type)for stored and composed Variant values, extending the existing getter cast rewrite to use root extraction. Preserve explicit intermediate conversions and dispatch using Variant extension metadata, while reusing the existing getter and Arrow kernels.Add SQL coverage for materialized results and schemas, strict/try behavior, composed expressions, Binary/LargeBinary storage, shredded inputs, and ordinary struct casts. Extend the registration-order test and document the new syntax. A skipped assertion records an existing Arrow limitation: casting shredded Variant null to a struct yields a valid struct of null fields instead of SQL NULL.
Validation:
cargo test --offline(unit, SQL, README, and doc tests),cargo fmt --all -- --check,cargo clippy --offline -- -D warnings, andgit diff --checkpassed. Benchmarks were not run.Closes #90. Related to #71.