Repository navigation
Conversation
The interactive CLI example is superseded by dfv (#102), a datafusion-cli with the Variant functions preinstalled. Drop the example, its rustyline dev-dependency, and the README instructions for it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
commented
Oct 28, 2026
| #[tokio::main] | ||
| async fn main() -> Result<()> { | ||
| // todo: we can let users pass in arbitrary files to load | ||
| // for now, we'll directly use bluesky's data |
|
|
||
| ## More examples and benchmarks | ||
|
|
||
| The [interactive CLI](https://github.com/datafusion-contrib/datafusion-variant/blob/main/examples/cli.rs) |
The jsonbench prepare command downloads the same Bluesky files itself, so the script is redundant. Point profile_parse_json at that command instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…xample" This reverts commit dc10c77.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I am adding an easier to use interactive shell,
dfv(adatafusion-cliwith the Variant functions preinstalled), in #102. The hand-rolledexamples/cli.rsREPL duplicates that and is less capable, so this PR removes it.What changes are included in this PR?
examples/cli.rsrustylinedev-dependency, which was only used by the example (flate2anddownload_data.shstay, as the benchmarks use them)dfv/ Update examples in README, Add dvf with Variant functions preinstalled #102Are these changes tested?
cargo check --examples --testspasses. No functional code is changed.Are there any user-facing changes?
cargo run --example clino longer exists. Usedfvfrom #102 instead.