Fix normalizer crash on comments after line continuations - #244
Closed
be-student wants to merge 1 commit into
Closed
be-student wants to merge 1 commit into
be-student wants to merge 1 commit into
Conversation
Owner
|
Is this fully LLM? How did you even discover this? Why do you want to fix this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment after a line continuation can make the PEP8 normalizer walk past the root of its saved indentation stack. Stop at that root when the current continuation node is newer than the saved stack.
Closes #219. Adds 27 regression variants covering line endings, comments, and preceding statements/suites, while checking that the missing-final-newline diagnostic is preserved. Includes the required changelog and author entries.
Validation: all 27 variants failed before the fix; the full suite now passes (2,016 tests). Flake8, Zuban (49 source files), and
git diff --checkpass. Tested locally on Python 3.12/macOS; the remaining CI interpreter matrix was not run locally.