[feat] Add option to prefetch completion metadata and to persist completion metadata when switching schemas#1857
Open
scottnemes wants to merge 3 commits intodbcli:mainfrom
Open
Conversation
| # (empty) = default, disables prefetching | ||
| # schema1,schema2 = enables prefetch for given schemas | ||
| # all = enables prefetch for all schemas | ||
| prefetch_schemas = |
Contributor
There was a problem hiding this comment.
Why off by default? Also, all is a valid schema name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently completion suggestions only populate / apply for the selected schema, and when you switch schemas, all completions are cleared. This PR does a few important things:
usecommand), completions are fetched for that schemas as usual. However if the user switches schemas again, the completions for the previously selected schema are now saved (this is independent of prefetching). So if you "use db1", then "use db2", completions for both db1 and db2 will now be available in addition to any prefetched schemas.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).