⚡ Bolt: [performance improvement] Replace iterrows with to_dict('records')#89
⚡ Bolt: [performance improvement] Replace iterrows with to_dict('records')#89alinelena wants to merge 1 commit into
Conversation
…rds') Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
df.iterrows()withdf.to_dict('records')inverify_processed_omol25.py, and updated downstream dictionary constructors and method calls (pq_row.to_dict()->dict(pq_row)).🎯 Why:
df.iterrows()is a known pandas anti-pattern that creates significant performance overhead by yielding a newSeriesobject for every single row. Furthermore, the original code ran it twice, storing pandasSeriesobjects in memory which consumes a massive amount of memory for large dataframes.📊 Impact: Expected to provide a massive speedup in iteration time (as dictionary conversions happen at the C-level) and drastically reduce memory overhead (native Python dictionaries are much lighter than pandas Series objects).
🔬 Measurement: Verify by running the data verification script on a large parquet dataset and observing the processing time drop.
PR created automatically by Jules for task 8365578486972164348 started by @alinelena