feat: add md stability benchmark#644
Conversation
|
Hi @lwehrhan, from a brief look this is looking nice and i think wont need many comments from us. Could you please take a look at the element filtering mentioned by @ElliottKasoar in #429, it should be pretty straightforward to add. then we will take a deeper look over. thanks! |
ElliottKasoar
left a comment
There was a problem hiding this comment.
Does the benchmark save anything in terms of the trajectories? It might be interesting to see, for example, how far a simulation gets before exploding, even if it doesn't form a part of the score.
Either through that, or otherwise, it might also be nice to be able to see which systems were successfully simulated or not. Do you think this might be possible?
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
|
Thanks for the pr! same as #658 could you send the data + have a look at the element filtering? docs: https://ddmms.github.io/ml-peg/developer_guide/filter.html |
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
This benchmark tests if an MLIP can run stable simulations of various organic small molecules and peptides (in vacuum and in solution), as well as of a protein in vacuum.
Linked issue
Resolves #640
Progress
Testing
New decorators/callbacks