autocomplete cli for tests and models#683
Open
joehart2001 wants to merge 2 commits into
Open
Conversation
|
|
||
| from ml_peg.models import MODELS_ROOT | ||
|
|
||
| with open(MODELS_ROOT / "models.yml", encoding="utf8") as handle: |
Collaborator
There was a problem hiding this comment.
We probably want to do something closer to what we do in list_models where we use the models_file (so the models we autocomplete with is from the correct list) and get_model_names, (so we're not rewriting parsing, if we need to change something)
Collaborator
Author
There was a problem hiding this comment.
what do you think now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Linked issue
Resolves #
Testing