Retire obsolete Decent Scale Off plugin - #352
Open
ODevStudio wants to merge 2 commits into
Open
Conversation
ODevStudio
marked this pull request as ready for review
July 27, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decent Scale Offas an inert compatibility shimdecentscale_offenablement out of settingsRoot cause
The plugin replaced the core
scale_disable_lcdprocedure and delayed the scale power-off write by three seconds. The normal sleep path disconnects the scale after one second, so the connection could close before the plugin sent the command. Core app code now owns this behavior and queues power-off before disconnecting.Impact
Existing installations receive the inert shim through the updater, while new users cannot enable the obsolete plugin. Persisted enablement is removed and saved once, preventing an older plugin copy from reactivating after a channel downgrade. The core
keep_scale_onbehavior remains unchanged.Validation
tests/decentscale_off.test.tcl: 3 passedgit diff --checkscale_disable_lcdbefore the delayed disconnect