Skip to content

chore: debug view & bengle fw update #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tadelv merged 3 commits into from
Aug 25, 2026
Merged

chore: debug view & bengle fw update #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
002980c
scroallable debug view
tadelv Aug 21, 2026
f0daf5b
batch pause increase for bengle
tadelv Aug 22, 2026
b300cd2
fix(debug): bottom inset for debug view lists
tadelv Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lib/src/debug_feature/debug_item_details_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,17 @@ class _De1DebugViewState extends State<De1DebugView> {
),
actions: [_buildStateDropdown(context)],
),
body: LayoutBuilder(
builder: (context, constraints) {
final isWide = constraints.maxWidth > 900;
if (isWide) {
return _buildWideLayout(theme);
}
return _buildNarrowLayout(theme);
},
body: SafeArea(
top: false,
child: LayoutBuilder(
builder: (context, constraints) {
final isWide = constraints.maxWidth > 900;
if (isWide) {
return _buildWideLayout(theme);
}
return _buildNarrowLayout(theme);
},
),
),
);
}
Expand Down Expand Up @@ -284,6 +287,7 @@ class _De1DebugViewState extends State<De1DebugView> {
crossAxisAlignment: CrossAxisAlignment.start,
mainAxisSize: MainAxisSize.min,
children: [
Text('Firmware: ${widget.machine.machineInfo.version}'),
ShadButton.outline(
size: ShadButtonSize.sm,
child: const Text('Firmware Update'),
Expand Down
8 changes: 7 additions & 1 deletion lib/src/models/device/impl/bengle/bengle.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import 'package:reaprime/src/models/device/impl/de1/de1.models.dart';
import 'package:reaprime/src/models/device/impl/de1/unified_de1/bengle_shot_sample.dart';
import 'package:reaprime/src/models/device/impl/de1/unified_de1/unified_de1.dart';
import 'package:reaprime/src/models/device/machine.dart';
import 'package:reaprime/src/models/device/transport/data_transport.dart';
import 'package:reaprime/src/models/errors.dart';
import 'package:rxdart/rxdart.dart';

Expand Down Expand Up @@ -45,7 +46,12 @@ class Bengle extends UnifiedDe1

@override
@protected
Duration get firmwareUploadBatchPause => Duration.zero;
Duration get firmwareUploadBatchPause {
return switch (transportType) {
TransportType.serial => const Duration(milliseconds: 20),
_ => Duration.zero,
};
}

final BehaviorSubject<double> _stopAtTempTarget =
BehaviorSubject<double>.seeded(0.0);
Expand Down
Loading