Repository navigation
fix(transaction): prevent unauthorized updates by validating existing transaction ownership - #70
Merged
Merged
Conversation
dedyf5
commented
Oct 13, 2026
dedyf5
commented
Owner
- Fix security vulnerability where updates relied solely on payload validation, allowing users to modify unauthorized existing transactions if the new payload targeted an authorized branch.
- Add existing transaction lookup via TransactionGetByPublicID scoped to the user's permitted branches before processing the update.
- Expand unit tests to verify access control errors (403/404) on existing records.
… transaction ownership - Fix security vulnerability where updates relied solely on payload validation, allowing users to modify unauthorized existing transactions if the new payload targeted an authorized branch. - Add existing transaction lookup via TransactionGetByPublicID scoped to the user's permitted branches before processing the update. - Expand unit tests to verify access control errors (403/404) on existing records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.