refactor: remove the unused Sockets.__getattribute__ override

haystack/core/component/sockets.py

@@ -2,7 +2,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-from typing import Any
 
 from haystack.core.type_utils import _type_name
 
@@ -123,16 +122,6 @@ def _component_name(self) -> str:
         # __repr__ method and that would lead to infinite recursion since we call Sockets.__repr__ in it.
         return object.__repr__(self._component)
 
-    def __getattribute__(self, name: Any) -> Any:
-        try:
-            sockets = object.__getattribute__(self, "_sockets")
-            if name in sockets:
-                return sockets[name]
-        except AttributeError:
-            pass
-
-        return object.__getattribute__(self, name)
-
     def __repr__(self) -> str:
         result = ""
         if self._sockets_io_type == InputSocket:

releasenotes/notes/fix-sockets-getattribute-lookup-7c31a9f4e28b5d16.yaml

@@ -0,0 +1,9 @@
+---
+enhancements:
+  - |
+    Removed the ``Sockets.__getattribute__`` override. It looked up a ``_sockets``
+    attribute that no instance has, so on every attribute access it raised and
+    caught ``AttributeError`` and never returned a socket; socket access has always
+    gone through the copies ``__init__`` and ``__setitem__`` put in ``__dict__``.
+    Without the override, accessing a socket attribute such as
+    ``component.__haystack_input__.query`` is about 14x faster.