Repository navigation
Conversation
An empty or whitespace-only candidate was previously treated as configured and blocked fallback to later variables.
|
@yongpange is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @yongpange, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
Related Issues
Proposed Changes:
Secret.from_env_varusedos.getenvand stopped at the first variable that was present, including""and whitespace. A blankHF_TOKENtherefore blocked fallback toHF_API_TOKEN, andstrict=Truereturned""instead of raising.The resolver now treats empty or whitespace-only values as unset, matching the usual "set means has a real value" contract for auth env vars.
How did you test it?
test_env_var_secret_treats_blank_values_as_unsetmainwith a blank first candidate and a real fallback; after the fix the fallback is used and a strict blank-only secret raisesValueErrorNotes for the reviewer
Same contract as #12723, rebased onto current
main(the old branch was ~255 commits behind). I will sign the CLA immediately if the check is still pending.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.