Repository navigation
fix: validate ComponentTool custom parameters - #13211
Open
D1822787566 wants to merge 1 commit into
Open
D1822787566 wants to merge 1 commit into
D1822787566 wants to merge 1 commit into
Conversation
Contributor
|
@D1822787566 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @D1822787566, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
HaystackBot
marked this pull request as draft
October 11, 2026 08:55
HaystackBot
marked this pull request as ready for review
October 11, 2026 09:31
Contributor
|
Thanks for signing the CLA, @D1822787566! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
ComponentToolnow validates customparametersschemas against the wrapped component's input sockets during construction. Unknown top-level properties raise a clearValueErrorbefore tool invocation, instead of causing a lateKeyErrorwhen the tool is called.The existing JSON Schema validation and support for implicit schemas remain unchanged.
How did you test it?
hatch -e test run pytest test/tools/test_tool.py test/tools/test_component_tool.py -qhatch run ruff check haystack/tools/component_tool.py test/tools/test_component_tool.pyhatch run ruff format --check haystack/tools/component_tool.py test/tools/test_component_tool.pyNotes for the reviewer
The change is intentionally limited to explicit custom schema properties. It does not require every component input to be listed, preserving existing schemas that rely on implicit or state-provided inputs.
This PR was fully generated with an AI assistant. I have reviewed the changes and run the relevant tests.
Checklist