Repository navigation
refactor: simplify ChatMessage serialization/OpenAI conversion - #13275
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
topic:tests
type:documentation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
anakin87
commented
Oct 15, 2026
| @@ -35,7 +35,31 @@ def test_function_role_removed(self): | |||
| ChatRole.from_str("function") | |||
|
|
|||
|
|
|||
Member
Author
There was a problem hiding this comment.
in this file, I just reordered the existing tests into focused classes and added 2-3 tests for uncovered paths
anakin87
changed the title
ChatMessage serialization/OpenAI conversion
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
I noticed that
ChatMessageserialization and conversion from/to OpenAI became complex and a bit hard to followProposed Changes:
ChatMessage/ToolCallResultserializationto_openai_dict_formatinto helpersHow did you test it?
CI. Added 2-3 tests.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.