Skip to content

fix: support typing.Annotated in type serialization - #13304

Open
rxchitrx wants to merge 3 commits into
deepset-ai:mainfrom
rxchitrx:fix/annotated-type-serialization
Open

rxchitrx wants to merge 3 commits into
deepset-ai:mainfrom
rxchitrx:fix/annotated-type-serialization

Conversation

@rxchitrx

Copy link
Copy Markdown
Contributor

fixes #12338, mirrors #12286 Literal approach - repr() on serialize, ast.literal_eval + quote-aware splitter on deserialize, plus round-trip tests

@rxchitrx
rxchitrx requested a review from a team as a code owner October 17, 2026 06:24
@rxchitrx
rxchitrx requested review from bogdankostic and removed request for a team October 17, 2026 06:24
@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

@rxchitrx is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @rxchitrx, thanks for your interest in contributing to Haystack! 🙏

⚠️ Issue #12338 is already being addressed by open pull request(s) #2. Before opening a PR for an issue, please check whether a PR is already linked to it, and consider contributing to the existing PR instead. We may close duplicate PRs to keep the review queue manageable.

This is an automated message to help us keep the review queue healthy.

@github-actions github-actions Bot added P2 Medium priority, add to the next sprint if no P1 available topic:tests labels Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/core/pipeline
  pipeline.py
  haystack/utils
  type_serialization.py 149, 151
Project Total  

This report was generated by python-coverage-comment-action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Medium priority, add to the next sprint if no P1 available topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: serialize_type / deserialize_type do not support typing.Annotated

1 participant