Repository navigation
fix: recognize indented Markdown headers - #13352
Conversation
|
@JackyHsu-X is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @JackyHsu-X, thanks a lot for your contribution! 🙏 We noticed that the Contributor License Agreement (CLA) check ( To get your PR reviewed, please sign the CLA via the link in the |
|
|
|
Thanks for signing the CLA, @JackyHsu-X! 🎉 This PR is now ready for review again and the reviewer has been re-assigned. |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
davidsbatista
left a comment
There was a problem hiding this comment.
thanks for the contribution
Related Issues
No existing issue. This is separate from #13104 (tabs after the header prefix) and #13344 (code fences).
Proposed Changes:
MarkdownHeaderSplitterignores valid ATX headings such as## Install, merging their sections and losing header metadata used for retrieval. Accept up to three leading spaces, as specified by CommonMark, while preserving the original content. Four-space and tab-indented lines remain content.Add regression coverage for header hierarchy, page numbers, both
keep_headersmodes, secondary splitting, selected levels, and code-block exclusion. Update the docstring, docs, and release note.How did you test it?
On Windows / Python 3.12, using the project's Hatch environments:
hatch run fmt-check, scoped mypy on both changed Python files, and all applicable pre-commit hooks passed.The full repository test suite, live integrations, and documentation build were not run.
Notes for the reviewer
Fully generated with Codex at the author's request. Codex ran the local checks reported above.
Checklist