Terminal state logic change for upload api#4303
Open
Venu-p1 wants to merge 2 commits into
Open
Conversation
…ELLED) to enable retry scenarios, only block tombstoned jobs
Collaborator
Rajeshkumar-s2
left a comment
Rajeshkumar-s2
left a comment
There was a problem hiding this comment.
Hi Venu,
This is part of resume/retry which we have not yet picked up. So, I have partially handled it for failed jobs in this PR itself (#4297). If not handled, it was difficult to test the new pipeline.
Hence handled it partially now and As part of resume/retry we can completely handle for all job states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow file uploads for jobs in terminal states (FAILED/COMPLETED/CANCELLED) to enable retry scenarios, only block tombstoned jobs