feat: add cdf, domain_metadata, appTxn, checkpoint, and crc spec types#56
Open
rliao147 wants to merge 3 commits into
Open
feat: add cdf, domain_metadata, appTxn, checkpoint, and crc spec types#56rliao147 wants to merge 3 commits into
rliao147 wants to merge 3 commits into
Conversation
This PR adds a write spec, which allows DAT workloads to test Delta writers. Any Delta writer can validate their own write APIs through the existing read/snapshot specs.
rliao147
force-pushed
the
stack/add-missing-ops
branch
from
95f9bbb to
88cfc7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Description
Builds on the read/snapshot/write spec types to add more read-side spec types:
_change_type/_commit_version/_commit_timestamp.configuration/removedat a version.SetTransaction(appId/txnVersion).crcspec is validated only where a.crcexists at that version (the version-checksum file is protocol-optional to write)cdf reads through the DataFrame change-feed API;
domain_metadataandappTxnread via two new neutralSnapshotViewaccessors (domainMetadataJson,setTransactionsJson); checkpoint and crc read log artifacts directly.How was this patch tested?
Added multiple new test suites for the new specs, and existing suites pass. Also validated new against OSS spark/delta-kernel-rs.