feat: wasm-bindgen 0.2.108#169
Open
dsherret wants to merge 2 commits into
Open
Conversation
|
I really need this. Is there a way to get this merged? |
This was referenced Jul 5, 2026
…shape
Since wasm-bindgen 0.2.107, in bundler mode Output::js() returns the
small entry module and Output::start() returns the _bg.js bindings
glue (previously js() was the glue and start() was just the start
snippet). wasmbuild generates its own entry file, so it was writing
the wasm-bindgen entry out as {name}.internal.{ext}, which referenced
never-emitted {name}_bg.js/{name}_bg.wasm files and failed type
checking.
Take the glue from start(), and expose an explicit hasStart flag
(derived from whether the entry calls __wbindgen_start) instead of
returning the raw start snippet.
|
|
Member
|
@dsherret any objections to landing and releasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.