Skip to content

fix: correct overstated README scope, add AI-DLC scaffold, dedupe analyze-path wiring - #18

Merged
derek-palmer merged 2 commits into
mainfrom
techdebt-verify-and-fix
Sep 10, 2026
Merged

derek-palmer merged 2 commits into
mainfrom
techdebt-verify-and-fix

Conversation

@derek-palmer

@derek-palmer derek-palmer commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verify-and-fix pass over TechDebtter: confirm the product does what its docs claim, correct documentation that overstated the code, and fix small contained defects. No new product capability.

  • README.md: opening description claimed continuous detection across eight technical-debt categories; only vulnerability scanning (Trivy + KEV/EPSS) is implemented. Rewrites the description to state that scope plainly, moves the eight-category language to a Roadmap section, and documents the previously-undocumented observe/verify CLI subcommands in Usage.
  • SPEC.md / docs/architecture.md: adds the missing FindingVerificationGateway port to both port lists (six documented, seven actually exist). SPEC.md C10 claims live external smoke tests run on a schedule; confirmed that half is unimplemented — no committed workflow file has an on: schedule trigger, and a repo admin checked the repo's Settings → Actions → Scheduled workflows page and found none registered there either. C10's other half (deterministic tests/checks block main) is unaffected and remains satisfied via ci.yml.
  • src/wiring/dependency-wiring.ts (new): extracts the CLI/Action analyze-path dependency wiring that was genuinely duplicated between src/cli/bootstrap.ts and src/action/main.ts. Preserves both entry points' existing behavioral divergences unchanged — CLI's hardcoded organization-policy stub vs. Action's live GitHub read, and differing cache-root paths — surfaced and corrected across three rounds of adversarial design review before implementation.
  • 6 new tests: verify existing security invariants that were previously untested — no working-tree mutation during analyze, dirty-worktree rejection, policy-resolution authority chain, write-token isolation in the new wiring, and GitHub Actions SHA-pinning.
  • .claude/ + aidlc/: adds the AI-DLC orchestrator scaffold and this intent's full workflow record (questions, decisions, reviews, design artifacts) as a separate commit ahead of the product fix.

152/152 tests passing (22 new), typecheck and lint clean, no dependency or public-contract change.

Test plan

  • npm run build — all 3 tsup targets succeed
  • npx vitest run — 152/152 passing
  • npx tsc --noEmit — clean
  • npx eslint src test — clean
  • Human: checked repo Settings → Actions → Scheduled workflows — none registered, confirming SPEC.md C10's scheduled smoke-test workflow does not exist anywhere (repo or GitHub Settings)

derek-palmer and others added 2 commits September 10, 2026 08:56
Adds the AI-DLC (AI-Driven Development Life Cycle) orchestrator shell
(.claude/) and the techdebt-remediation-agent intent's full workflow
record (aidlc/) produced while running Ideation through Construction
against this repository: questions, decisions, reviews, and design
artifacts for the verify-and-fix pass in the following commit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…th wiring

README's opening description claimed continuous detection across eight
technical-debt categories; only vulnerability scanning (Trivy + KEV/EPSS
enrichment) is implemented. Rewrites the description to state that scope
plainly, moves the eight-category language to a Roadmap section, and adds
the previously-undocumented observe/verify CLI subcommands to Usage.

Also:
- Adds the missing FindingVerificationGateway port to SPEC.md I9 and
  docs/architecture.md's port lists (six documented, seven actually exist).
- Marks SPEC.md C10's scheduled smoke-test claim as unverified from within
  the repository; no evidence of the workflow exists under
  .github/workflows/, but its existence outside the repo (GitHub Settings)
  couldn't be checked without repo-admin access.
- Extracts the CLI/Action analyze-path dependency wiring, previously
  duplicated between src/cli/bootstrap.ts and src/action/main.ts, into
  src/wiring/dependency-wiring.ts. Preserves both entry points' existing
  behavioral divergences unchanged (CLI's hardcoded organization-policy
  stub vs. Action's live GitHub read; differing cache-root paths).
- Adds six tests verifying existing security invariants that were
  previously untested: no working-tree mutation during analyze, dirty
  worktree rejection, policy-resolution authority chain, write-token
  isolation in the new wiring, and GitHub Actions SHA-pinning.
- Scopes eslint.config.js's ignores to exclude .claude/ and aidlc/ (the
  AI-DLC framework scaffold and its workflow records, added in the prior
  commit) from the product's lint rules; CI's `npm run check` lints the
  whole repository with no per-directory files: restriction, so committing
  that scaffold without this exclusion broke CI on framework-tooling lint
  errors unrelated to this fix.

152/152 tests passing (22 new), typecheck and lint clean, no dependency or
public-contract change.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@derek-palmer
derek-palmer force-pushed the techdebt-verify-and-fix branch from ace1540 to 1b937fc Compare September 10, 2026 12:56
@derek-palmer derek-palmer self-assigned this Sep 10, 2026
@derek-palmer

Copy link
Copy Markdown
Owner Author

There's no scheduled trigger/action created. Revisiting AIDLC and will update PR.

@derek-palmer
derek-palmer merged commit 6540d33 into main Sep 10, 2026
2 checks passed
@derek-palmer
derek-palmer deleted the techdebt-verify-and-fix branch September 10, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant