Fix broken golangci-lint installation in go feature#1632
Open
max06 wants to merge 2 commits intodevcontainers:mainfrom
Open
Fix broken golangci-lint installation in go feature#1632max06 wants to merge 2 commits intodevcontainers:mainfrom
max06 wants to merge 2 commits intodevcontainers:mainfrom
Conversation
ldez
reviewed
May 2, 2026
There was a problem hiding this comment.
We (golangci-lint maintainers) recommend using https://golangci-lint.run/install.sh instead of an URL based of a branch.
https://golangci-lint.run/docs/welcome/install/local/#binaries
This is for several reasons:
- GitHub applies new rate limits
- Referencing a branch can be brittle
Use official url for the install-script Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
|
Confirming this hits us on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently using the go-feature in devcontainers without specifying an older version to install breaks building devcontainers.
After investigating, 2 reasons were identified for breaking:
This should be merged quickly.
Potential workaround: Using
v2.11.4as version for golangci-lint should work since sbom-files were added in v2.12 for the first time.