Repository navigation
fix: stack Date & Location venue cards on mobile and tablet - #26
Closed
ashton-arinze wants to merge 1 commit into
Closed
ashton-arinze wants to merge 1 commit into
ashton-arinze wants to merge 1 commit into
Conversation
The venue showcase grid kept its two-column layout at every width, crushing the campus card into a narrow strip on phones. Stack the cards below 900px and tighten padding, transit cards and action buttons at 600px and below.
Author
|
Superseded: reopening from the LogicalOgbonna account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On phones the Date & Location section was broken.
.venue-showcase-containeris a two-column grid (1fr 1.25fr) with no responsive rule, so it stayed two columns at every width. On a 390px screen:Before (live site, 390px):
Fix
CSS only, in
src/assets/css/custom.css:After (local, 390px):
After (local, 768px tablet):
Desktop (1280px), unchanged:
Testing
npm run devlocally and checked the section at 360, 390, 768 and 1280px.scrollWidthequals the viewport width).npm run buildsucceeds.