Try mismatching adapter code

[dgirardi]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Updated bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Other information

[github-actions]

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named BidAdapter, userId IdSystem, RTD RtdProvider, and analytics Analytics.

[github-actions]

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

[github-actions]

Some adapters in this PR do not follow Prebid naming conventions.

• Module zeta_global_sspBidAdapter defines bidder code zeta_global_ssp, which conflicts with:
  • bidder code zeta_global defined in module zeta_globalBidAdapter

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/pwbidBidAdapter.js has 28 duplicated lines with modules/zeta_global_sspBidAdapter.js
• modules/zeta_global_sspBidAdapter.js has 32 duplicated lines with modules/zmaticooBidAdapter.js
• modules/zeta_global_sspBidAdapter.js has 22 duplicated lines with modules/zmaticooBidAdapter.js
• modules/zeta_global_sspBidAdapter.js has 21 duplicated lines with modules/zmaticooBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀