DX-120970 Truncate subseconds beyond milliseconds in castTIMESTAMP_utf8 and castTIME_utf8 (cherry-pick to 26.1)#140
Merged
akravchukdremio merged 2 commits intoJun 3, 2026
Conversation
…s in `castTIMESTAMP_utf8` and `castTIME_utf8` (apache#48867) ### Rationale for this change Fixes apache#48866. The Gandiva precompiled time functions `castTIMESTAMP_utf8` and `castTIME_utf8` currently reject timestamp and time string literals with more than 3 subsecond digits (beyond millisecond precision), throwing an "Invalid millis" error. This behavior is inconsistent with other implementations. ### What changes are included in this PR? - Fixed `castTIMESTAMP_utf8` and `castTIME_utf8` functions to truncate subseconds beyond 3 digits instead of throwing an error - Updated tests. Replaced error-expecting tests with truncation verification tests and added edge cases ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#48866 Authored-by: Arkadii Kravchuk <arkadii.kravchuk@dremio.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs
previously approved these changes
May 28, 2026
…e brew pin - Replace unavailable buildjet-8vcpu-ubuntu-2204-arm with ubuntu-24.04-arm - Add docker-compose shim: ubuntu-24.04-arm ships only Docker Compose v2 as a plugin (docker compose); archery requires the standalone binary - Remove brew pin cmake/boost: newer Homebrew (runner >=20260525) resolves cmake via the API and hits the cmake cask when pinning; the pins are not needed in CI since no brew upgrade runs after the local tap install - Fix stale comment: remove "Add commentMore actions" GitHub UI artifact
akravchukdremio
force-pushed
the
DX-120970-26.1
branch
from
e4bb270 to
6dce7d1
Compare
Author
|
I've added this commit: 6dce7d1 to fix this build issue: https://github.com/Vijeth-test/arrow-build/actions/runs/26588412994/job/78340530613 Now after adding this commit, build is passing, see here https://github.com/Vijeth-test/arrow-build/actions/runs/26851749448/job/79185288106#step:6:72 and here: https://github.com/Vijeth-test/arrow-build/actions/runs/26851837270 |
lriggs
approved these changes
Jun 3, 2026
akravchukdremio
merged commit 7559af6
into
dremio:dremio_26.1_18.1.0
5 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #114 into
dremio_26.1_18.1.0(v26.1).The Gandiva precompiled time functions
castTIMESTAMP_utf8andcastTIME_utf8reject timestamp and time string literals with more than 3 subsecond digits (beyond millisecond precision), throwing an "Invalid millis" error. Customer T. Rowe Price is impacted on 25.2 and likely also affected on 26.1.Changes:
castTIMESTAMP_utf8andcastTIME_utf8functions to truncate subseconds beyond 3 digits instead of throwing an errorRisk Assessment
castTIMESTAMP_utf8andcastTIME_utf8in Gandiva precompiled time library onlyConflict Resolution
Test Plan
dremio_26.1_18.1.0branchJIRA: https://dremio.atlassian.net/browse/DX-120970