Remove bounds checks from filter_signal - #10
Open
valadaptive wants to merge 1 commit into
Open
valadaptive wants to merge 1 commit into
valadaptive wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gammatone filterbank is the hottest function in this code by far.
I noticed that the
filter_signalfunction seemed to contain a lot of bounds checks, one per coefficient. Because bounds checks are control flow, they can prevent many useful optimizations.By passing
numerator_coeffs,denom_coeffs, andinit_conditionsas references to fixed-size arrays rather than slices, the compiler knows all our accesses are inbounds, and can omit the bounds checks.This allows the code to be vectorized, and is 30-40% faster on my benchmarks.
Performance can probably be improved a lot further with some heavier reworks, but this is a small change that's easy to review.