fix(frontend-v2): pin eslint to v9 for plugin compatibility#430
fix(frontend-v2): pin eslint to v9 for plugin compatibility#430jakehobbs wants to merge 2 commits into
Conversation
ESLint 10 removed context.getFilename(), which eslint-plugin-react@7.37.5 (pulled in by eslint-config-next@16.2.6) still calls, crashing every lint run with "contextOrFilename.getFilename is not a function". No fixed plugin/config-next release exists yet, so revert to the latest 9.x until upstream ships ESLint 10 support. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 53 minutes and 31 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR downgrades/pins the frontend-v2 ESLint dependency to the supported v9 range so the Next.js ESLint config and transitive React plugin can run without the ESLint 10 API incompatibility.
Changes:
- Updates
eslintfrom^10.4.0to^9.39.4. - Refreshes the frontend-v2 lockfile so ESLint-related dependencies resolve against ESLint 9.39.4.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend-v2/package.json |
Changes the frontend-v2 devDependency range for ESLint to v9. |
frontend-v2/pnpm-lock.yaml |
Updates resolved ESLint and related peer dependency snapshots to ESLint 9.39.4. |
Files not reviewed (1)
- frontend-v2/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
With eslint runnable again, eslint-plugin-react-hooks@7 flagged 5 errors: - date-range-filter: replace prop->state mirroring effect with React's adjust-state-during-render pattern (no cascading re-render). - useActivistRegistry: hold the ActivistRegistry in a lazy useState instead of a ref so it can be read during render (also avoids constructing a throwaway instance every render). - useActivistRegistry: annotate two one-shot loading-flag setState calls in effects with targeted eslint-disable + justification. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review summaryI reviewed the workspace diff: an eslint downgrade (
No findings to flag. The changes are correct, behavior-preserving, and well-commented. The eslint pin to v9 is reasonable given |
ESLint was bumped to 10.4.0 by dependabot (commit 0ff3e83), but ESLint 10 removed
context.getFilename(), whicheslint-plugin-react@7.37.5(pulled in transitively byeslint-config-next@16.2.6) still calls — crashing every lint run withcontextOrFilename.getFilename is not a function. This is a known upstream issue with no fixedeslint-plugin-react/eslint-config-nextrelease yet, and the maintainer-tracked recommendation is to stay on ESLint v9 (whicheslint-config-next@16.2.6fully supports). This PR pinseslintback to^9.39.4so linting works again; we can re-bump to v10 once upstream ships compatibility.🤖 Generated with Claude Code