Fix mpl.cbook.matplotlib depreciation warning#39
Conversation
This symbol has moved from mpl.cbook.MatplotlibDepreciationWarning to mpl.MatplotlibDepreciationWarning
|
Thank you for your fix. |
|
Can confirm as described in the matplotlib API changes for 3.8.0: cbook removals. |
|
Checked and working great with the latest version of matplotlib! |
zhenyuan0502
left a comment
zhenyuan0502
left a comment
There was a problem hiding this comment.
This fix is necessary otherwise no newer matplotlib version supported
|
We also need to specify the versions of dependencies to ensure this lib to work. |
|
One last aprove needed. |
|
If anybody wants to make use of the fix until its pushed then you can always do the following: |
This code was responsible from hiding deprecation warnings if a key gets unused, but it causes more harm than good: mpl did refactor their deprecation system, and the code simply failed as the old mpl.cbook.MatplotlibDeprecationWarning didn't exist anymore. Instead of going the approach of e-hulten#39 or e-hulten#43 again and adjusting to the change, simply drop the deprecation warning hiding alltogether. It'll show when july starts using deprecated keys, so they can be updated. Also use `mpl.rcParams[key] = value` directly and drop the ConfigDict logic, as it's unneeded. Closes e-hulten#39. Closes e-hulten#43.
|
Alternative approach: #44 |
11 participants
Fix the
mpl.cbook.MatplotlibDeprecationWarningsymbol tompl.MatplotlibDeprecationWarning. Without this, july won't show any charts for newer versions of matplotlib.Also bump version number.