Update contact modal - #2657
Open
styrix560 wants to merge 35 commits into
Open
Conversation
styrix560
marked this pull request as ready for review
March 16, 2026 19:19
styrix560
force-pushed
the
2129-update-contact-modal
branch
from
March 16, 2026 20:29
41f249c to
013b600
Compare
fekoch
requested changes
Mar 16, 2026
styrix560
commented
Mar 16, 2026
styrix560
force-pushed
the
2129-update-contact-modal
branch
from
April 13, 2026 17:11
e262c2f to
b945b30
Compare
niklasmohrin
self-requested a review
April 13, 2026 17:21
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
I think the end goal should be to not use django include for modals at all; this is definitely a step in the right direction.
richardebeling
requested changes
Apr 13, 2026
richardebeling
removed their request for review
April 19, 2026 18:45
styrix560
force-pushed
the
2129-update-contact-modal
branch
from
May 4, 2026 18:06
62de043 to
2cccadb
Compare
niklasmohrin
requested changes
May 4, 2026
niklasmohrin
left a comment
niklasmohrin
left a comment
Member
There was a problem hiding this comment.
Tests look all good, some final touches:
richardebeling
approved these changes
Jun 8, 2026
janno42
requested changes
Jun 8, 2026
janno42
left a comment
janno42
left a comment
Member
There was a problem hiding this comment.
- Submitting the "Request changes" modal results in a
MultiValueDictKeyError. - The modal behaves strangely on a small screen with a low Y resolution. It should be made scrollable instead of the contents being placed out of view.
niklasmohrin
reviewed
Aug 3, 2026
| const confirmButtonExtraClass = this.getAttribute("confirm-button-class") ?? "btn-primary"; | ||
| confirmButton.className += " " + confirmButtonExtraClass; | ||
|
|
||
| const dialogExtraClass = this.getAttribute("dialog-extra-class"); |
Member
There was a problem hiding this comment.
we use this only one time to add overflow-scroll; should we just always put overflow: scoll into the css for the confirmation modal, or does that break anything?
Collaborator
Author
There was a problem hiding this comment.
Incidentally, this is my last PR where I put overflow: show into the css so that the TomSelect input does not get clipped at the confirmation modal border
Member
There was a problem hiding this comment.
okay, let's keep it like this for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2129