Repository navigation
Don't write default values for fixed parameters - #321
Merged
Merged
Conversation
This only happens if you open a project with a stale location - normally the picker would prevent you from giving a bad output destination. Currently fails silently, but an improvement over a hard crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EPS was adding the default values of non-varying parameters in the first and last audioBlockFormat
While not technically incorrect (the values are the same as would be implied if they were absent), it's unnecessary noise, and inconsistent with them being absent in intermediate audioBlockFormats.
This PR filters out non-varying default value points in the function that generates these values
It also fixes a crash bug present where a non-writable path is passed to the ADM pcm sink. In normal circumstances this can't happen, as the path picker only lets you choose valid places to export, but if you import a session to a new machine with a default location saved that is not present, you can hit the bug.
It currently just conceals the problem and fails to export, but that's better than a hard crash. Will add a new issue to wire up error reporting and/or export cancellation so we can feed back the problem to the user.